Wire artifacts fallback into DatasetRestoring test helpers#191
Merged
simone-silvestri merged 1 commit intomainfrom Apr 27, 2026
Merged
Wire artifacts fallback into DatasetRestoring test helpers#191simone-silvestri merged 1 commit intomainfrom
simone-silvestri merged 1 commit intomainfrom
Conversation
The shared helpers `test_ocean_metadata_utilities`, `test_dataset_restoring` and `test_timestepping_with_dataset_restoring` constructed `DatasetRestoring` directly, which calls `download_dataset` with no recovery path. When the upstream source (e.g. ECCO JPL) is unreachable or credentials are absent (as on fork PRs), every testset that uses these helpers fails before any test logic runs. Pre-resolve the metadata file paths and run `download_dataset(metadata)` through `download_dataset_with_fallback`, mirroring the pattern already used in the "Fields utilities" testsets, so missing files are pulled from NumericalEarthArtifacts before `DatasetRestoring` is constructed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
giordano
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More wiring of download defaults into the test suites. Follows #190 and should hopefully be the last one.
🤖 Generated with Claude Code